Add more tests for diagnostic messages #113
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
My PR adds very straightforward tests to trigger complilation errors with diagnostic notes. I didn't cover all library function and all error branches. But hopefully these basic tests could be helpul for future testing of library functions.
Covered functions:
reflect_invoke
identifier_of
template_of
type_of
parent_of
operator_of
value_of
object_of
extract
can_substitute
substitute
I tried to follow test files pattern so for related
*.pass.cpp
I added*.verify.cpp
files with validation of compilation error diagnostic.Additional context
Found at least 1 bug:
Code below doesn't produce an error and prints
A
. But in source code of functionidentifier_of
I see that we should error on this condition with notenames of constructors are not identifiers
Maybe I am missing something...